bugfix(_example): vars should be quoted (and disable unexported vars warning)
authorAJ ONeal <aj@therootcompany.com>
Tue, 23 Nov 2021 08:55:42 +0000 (08:55 +0000)
committerAJ ONeal <aj@therootcompany.com>
Tue, 23 Nov 2021 09:07:46 +0000 (09:07 +0000)
_example/install.sh

index cebf7a415cca647e8a4d8a964e6acf37c6d6c7d4..bd4a692582c719833cbf2a221f8b56fed059b593 100644 (file)
@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# shellcheck disable=SC2034
+# "'pkg_cmd_name' appears unused. Verify it or export it."
+
 function __init_foobar() {
     set -e
     set -u
@@ -21,10 +24,10 @@ function __init_foobar() {
     # pkg_install must be defined by every package
     pkg_install() {
         # ~/.local/opt/foobar-v0.99.9/bin
-        mkdir -p "$(dirname $pkg_src_cmd)"
+        mkdir -p "$(dirname "${pkg_src_cmd}")"
 
         # mv ./foobar-*/foo ~/.local/opt/foobar-v0.99.9/bin/foo
-        mv ./foobar-*/foo "$pkg_src_cmd"
+        mv ./foobar-*/foo "${pkg_src_cmd}"
     }
 
     # pkg_get_current_version is recommended, but not required